Use ConcurrentDictionary for options properties.#1234
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1234 +/- ##
==========================================
- Coverage 82.54% 82.54% -0.01%
==========================================
Files 697 697
Lines 30512 30511 -1
Branches 3469 3469
==========================================
- Hits 25187 25186 -1
Misses 4605 4605
Partials 720 720
Continue to review full report at Codecov.
|
This was referenced Jun 16, 2020
tocsoft
approved these changes
Jun 17, 2020
4 tasks
This was referenced Jul 30, 2025
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix #1230 #1224
The two dictionaries used in
ConfigurationandDefaultImageProcessorContextwere not thread safe and would throw when accessed in a parallel context.I've replaced them with
ConcurrentDictionaryinstances which fixes the issue but I wonder whether we should be exposing the property asIDictionary<object, object>over the concrete type since we require thread safety.