PNG filter improvements#2226
Merged
JimBobSquarePants merged 2 commits intoSixLabors:mainfrom Sep 14, 2022
Merged
Conversation
JimBobSquarePants
approved these changes
Sep 14, 2022
Member
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Very cool. Much improved readability also. Thanks!
This was referenced Sep 29, 2025
This was referenced Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes a bug in the sums calculation for adaptive filtering:
ImageSharp/src/ImageSharp/Formats/Png/Filters/AverageFilter.cs
Line 217 in ea97bac
I can only guess this adjustment was compensating for a bug that existed in an earlier version of the code where it counted the row filter byte in the sum. In any case, that is not happening now, so the adjustment at the end is taking away from a valid sum value. Although this is generally harmless, it does mean that in the event of a tie for sum values (e.g. 0 in a solid color image), Paeth will win by virtue of its larger row filter number (-4 adjustment), making the resulting image needlessly expensive to decode.
Also tidies up the code and codegen for PNG filters in a few ways:
I will follow up another time with some improvements to the SIMD decode filter implementations. I have ideas 😉