-
-
Notifications
You must be signed in to change notification settings - Fork 446
Unprivate Arithmetics#exactOperationExists method #7206
Copy link
Copy link
Closed
Labels
PR availableIssues which have a yet-to-be merged PR resolving itIssues which have a yet-to-be merged PR resolving itenhancementFeature request, an issue about something that could be improved, or a PR improving something.Feature request, an issue about something that could be improved, or a PR improving something.priority: lowest"Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements)."Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Metadata
Metadata
Assignees
Labels
PR availableIssues which have a yet-to-be merged PR resolving itIssues which have a yet-to-be merged PR resolving itenhancementFeature request, an issue about something that could be improved, or a PR improving something.Feature request, an issue about something that could be improved, or a PR improving something.priority: lowest"Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements)."Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Type
Fields
Give feedbackNo fields configured for issues without a type.
Suggestion
Unprivate the
exactOperationExistsmethod on theArithmeticsclassWhy?
Currently addons have no real way of checking if operations for arithmetic are currently registered making usage of the register unsafe
Other
Step to fix
Skript/src/main/java/org/skriptlang/skript/lang/arithmetic/Arithmetics.java
Lines 75 to 81 in d826675
Agreement