Time Until expression

[colton-boi]

Description

Added time until syntax to time since expression

Target Minecraft Versions: Any
Requirements: None
Related Issues: #5766

[AyhamAl-Ali]

Nice PR ⚡

[TheLimeGlass]

Suggested change

	"[the] time since %dates%",
	"[the] (time [remaining]|remaining time) until %dates%");
	"[the] time since %dates%",
	"[the] (time [remaining]|remaining time) until %dates%");

[APickledWalrus]

Breaking change currently due to the change from null to 0 timespan for return type. Will need to discuss further potentially

[AyhamAl-Ali]

Ops, I didn't see Pickle's note..
I think returning 0 timespan will cause inaccurate results.

[Fusezion]

Ops, I didn't see Pickle's note.. I think returning 0 timespan will cause inaccurate results.

this was something I bought up and originally suggested the returning 0 timespan.
can you elaborate on areas where inaccurate results might be sent? (outside of passing a null value)

returning null on null values i'm perfectly fine with just any other case I believe 0 is better

[sovdeeth]

Ops, I didn't see Pickle's note.. I think returning 0 timespan will cause inaccurate results.

this was something I bought up and originally suggested the returning 0 timespan. can you elaborate on areas where inaccurate results might be sent? (outside of passing a null value)

returning null on null values i'm perfectly fine with just any other case I believe 0 is better

Null is consistent with other timespan expressions, namely time since. Changing both to 0 timespan would be consistent as well, but I think it's easier to go with what's already established. Edit: Didn't realize this was changing time since, which should have been obvious to me lol. My view remains that changing the established behavior doesn't really make sense here; there's no real benefit to 0 timespan vs null imo and the change in behavior isn't worth the slight improvement in intuition.

[UnderscoreTud]

Closed in favor of #6203