Deprecate outdated utils/synchronized reference#6671
Closed
kiip1 wants to merge 8 commits into
Closed
Conversation
* Mark VectorMath as internal * Replace usages
* Make Setter a Consumer. * Remove Setter from Option. * Remove setter from entry validator. * Remove setter from enum entry validator. * Remove setter from parsed entry validator. * Remove setter from parsed section validator.
* Make checker a Java predicate. * Deprecate unused Njol predicate for removal. * Make checker extensions use predicate directly. * Remove checker from expression. * Remove checker from utils. * Deprecate Checker for removal. * Abstract checker to predicate from simple syntax * Remove remaining uses of checker.
Moderocky
reviewed
May 8, 2024
Member
Moderocky
left a comment
Moderocky
left a comment
There was a problem hiding this comment.
This looks correct but I feel like it would be good for somebody to test it works first.
Moderocky
force-pushed
the
feature/deprecate-outdated-utils
branch
from
ebbf61b to
24c10f9
Compare
APickledWalrus
requested changes
Dec 17, 2024
Member
APickledWalrus
left a comment
APickledWalrus
left a comment
There was a problem hiding this comment.
If this happens to get taken over, I just have a function documentation-related thoughts. I am not a huge fan of the VectorMath changes, as there is a lot of method duplication going on now.
| import java.util.function.Predicate; | ||
|
|
||
| /** | ||
| * @author Peter Güttinger |
Member
There was a problem hiding this comment.
Suggested change
| * @author Peter Güttinger | |
| * @deprecated Use {@link Predicate} |
|
|
||
| import java.util.function.Predicate; | ||
|
|
||
| @Deprecated |
Member
There was a problem hiding this comment.
Suggested change
| @Deprecated | |
| /** | |
| * Use {@link Predicate} | |
| */ | |
| @Deprecated |
|
|
||
| import java.util.function.Function; | ||
|
|
||
| @Deprecated |
Member
There was a problem hiding this comment.
Suggested change
| @Deprecated | |
| /** | |
| * Use {@link Function} | |
| */ | |
| @Deprecated |
Comment on lines
26
to
27
| * @author Peter G�ttinger | ||
| * |
Member
There was a problem hiding this comment.
Suggested change
| * @author Peter G�ttinger | |
| * | |
| * @deprecated Use {@link java.util.function.Predicate} |
|
|
||
| import java.util.function.Consumer; | ||
|
|
||
| @Deprecated |
Member
There was a problem hiding this comment.
Suggested change
| @Deprecated | |
| /** | |
| * Use {@link Consumer} | |
| */ | |
| @Deprecated |
Member
|
Given this is rather outdated and seems to mostly be duplicated/featured in #6670, I will be closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.