Skip to content

Add missing tree types to prevent EvtGrow causing errors.#7230

Merged
APickledWalrus merged 3 commits into
SkriptLang:dev/patchfrom
sovdeeth:fix/evtgrow
Dec 1, 2024
Merged

Add missing tree types to prevent EvtGrow causing errors.#7230
APickledWalrus merged 3 commits into
SkriptLang:dev/patchfrom
sovdeeth:fix/evtgrow

Conversation

@sovdeeth
Copy link
Copy Markdown
Member

Description

Also adds a test to catch this in the future.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Nov 25, 2024
@ShaneBeee
Copy link
Copy Markdown
Contributor

while you’re in here, might as well update the missing trees?
https://github.com/SkriptLang/Skript/blob/dev/patch/src/main/java/ch/njol/skript/util/StructureType.java

# -- Tree Types --

@sovdeeth
Copy link
Copy Markdown
Member Author

while you’re in here, might as well update the missing trees? https://github.com/SkriptLang/Skript/blob/dev/patch/src/main/java/ch/njol/skript/util/StructureType.java

# -- Tree Types --

tbh didn't remember those existed lol

Comment thread src/main/java/ch/njol/skript/bukkitutil/ItemUtils.java Outdated
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
@Moderocky Moderocky added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Nov 30, 2024
@APickledWalrus
Copy link
Copy Markdown
Member

The StructureType class will be updated in a future PR.

@APickledWalrus APickledWalrus merged commit b163e26 into SkriptLang:dev/patch Dec 1, 2024
Burbulinis pushed a commit to Burbulinis/Skript that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants