Additional Dropped Item Elements#7270
Merged
APickledWalrus merged 27 commits intoApr 1, 2025
Merged
Conversation
Fusezion
suggested changes
Dec 17, 2024
Contributor
Fusezion
left a comment
Fusezion
left a comment
There was a problem hiding this comment.
iirc skript has a type registered for dropped entities can we make use of that instead of entity here so people don't interpret differently
APickledWalrus
requested changes
Dec 17, 2024
Fusezion
suggested changes
Dec 17, 2024
Contributor
Author
I'm not seeing any registered |
Contributor
it's likely |
Contributor
Author
ahhh ok, appreciate it |
Fusezion
suggested changes
Dec 17, 2024
APickledWalrus
requested changes
Dec 17, 2024
ShaneBeee
suggested changes
Dec 17, 2024
Absolutionism
requested review from
APickledWalrus,
Fusezion,
ShaneBeee and
sovdeeth
ShaneBeee
reviewed
Dec 17, 2024
Contributor
ShaneBeee
left a comment
ShaneBeee
left a comment
There was a problem hiding this comment.
Just some concerns I guess.
Efnilite
added
the
enhancement
Efnilite
requested changes
Dec 17, 2024
ShaneBeee
approved these changes
Dec 18, 2024
Contributor
ShaneBeee
left a comment
ShaneBeee
left a comment
There was a problem hiding this comment.
I'm still not a fan of returning null when something isn't null provided by Bukkit/Minecraft.
In my opinion this is super misleading.
ie: if owner/thrower of %itementity% is set: incorrectly returning false.
But if that is what the team wants, then I'll approve.
sovdeeth
requested changes
Dec 19, 2024
Efnilite
approved these changes
Dec 21, 2024
…tems # Conflicts: # src/main/java/ch/njol/skript/expressions/ExprEntityTamer.java
Absolutionism
requested review from
erenkarakal
and removed request for
Fusezion
sovdeeth
added
the
feature-ready
sovdeeth
requested changes
Mar 21, 2025
Member
sovdeeth
left a comment
sovdeeth
left a comment
There was a problem hiding this comment.
Also may want to update this PR to use UUID instead of string, though that's optional.
sovdeeth
removed
the
feature-ready
sovdeeth
requested changes
Mar 22, 2025
APickledWalrus
requested changes
Apr 1, 2025
sovdeeth
approved these changes
Apr 1, 2025
APickledWalrus
approved these changes
Apr 1, 2025
1 task
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add additional elements relating to Dropped Items. Allowing users to get+set the owners and the entity that dropped items, as well as make them not despawn.
Target Minecraft Versions: any
Requirements: none
Related Issues: #5110