Improve default comparator resolution#7287
Merged
sovdeeth merged 4 commits intoMar 21, 2025
Merged
Conversation
APickledWalrus
added
bug
Contributor
|
should we still retain the original check too? can we add a test? |
Member
Author
i'm not sure the original check ended up doing much (hence the need for this PR). if there were any cases where it was, they should still work with this PR, just with the classinfo resolution instead. |
Moderocky
approved these changes
Dec 24, 2024
sovdeeth
approved these changes
Dec 26, 2024
sovdeeth
added
the
feature-ready
APickledWalrus
added
the
don't merge me !!
Member
|
@APickledWalrus what's the state of this? |
APickledWalrus
added
2.11
and removed
don't merge me !!
Member
Author
Looking over it, it should be fine to merge. I can't imagine this would cause any issues (famous last words? 🙂). |
sovdeeth
removed
the
needs testing
Merged
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
Comparators: Compare CI rather than Class for last resort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the root issue that motivated PRs such as #7251. I have not reverted those changes, as it does not hurt to register the comparator directly. This needs further testing, but it should avoid the issues of allowing comparisons of unrelated classes that happen to share an interface (e.g. PersistentDataHolders).
Target Minecraft Versions: any
Requirements: none
Related Issues: none