Compatiblity patch for abandoned addons.#7356
Merged
Moderocky merged 5 commits intoJan 14, 2025
Merged
Conversation
Moderocky
added
up for debate
Efnilite
approved these changes
Jan 10, 2025
Moderocky
force-pushed
the
compatiblity-patch-converter
branch
from
48c4fd0 to
6f08794
Compare
APickledWalrus
approved these changes
Jan 13, 2025
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Moderocky
force-pushed
the
compatiblity-patch-converter
branch
from
e4a983f to
d6fc417
Compare
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Add back converter class stub. * Add caller error. * Alter message a bit. * Update src/main/java/ch/njol/skript/util/Utils.java * Remove method. ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Despite the legacy converters class being scheduled for removal several years ago, some addons have not removed code depending on it.
As this class is (was) removed in 2.10, these addons will fail to load unless they are recompiled.
Many addons are unaffected by this, since the alternative has been around for a long time.
Since this issue seemed quite widespread (based on a GitHub all-repositories search),
I have added a temporary 'patch' to make these addons load, using a stub of the removed class. The stub will print a large warning if an outdated addon tries to use the class, and a large amount of its (unsupported) functionality is no longer available, but it does mean that most outdated addons, e.g. skript-gui, will still load.
These stubs have the maximum amount of compile-time warnings and errors I can put on them, and they will be removed in future. This is not a permanent fix, just a temporary motivation for developers who have not updated their work in time.
Affected Classes
Example Warning
(This will presumably be red on a colour-supporting terminal.)