Skip to content

Allay Support#7358

Merged
erenkarakal merged 14 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/AllaySupport
Mar 31, 2025
Merged

Allay Support#7358
erenkarakal merged 14 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/AllaySupport

Conversation

@Absolutionism
Copy link
Copy Markdown
Contributor

@Absolutionism Absolutionism commented Jan 2, 2025

Description

This PR aims to add support for Allays. Allowing users to duplicate allays, set if allays can duplicate naturally, make them dance, duplication cooldown, and their target jukebox.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

Comment thread src/main/java/ch/njol/skript/effects/EffAllayCanDuplicate.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffAllayDancing.java Outdated
@Efnilite Efnilite added the feature Pull request adding a new feature. label Jan 2, 2025
Comment thread src/main/java/ch/njol/skript/conditions/CondIsDancing.java Outdated
@Absolutionism Absolutionism requested a review from Efnilite January 2, 2025 20:45
Comment thread src/main/java/ch/njol/skript/conditions/CondIsDancing.java Outdated
Copy link
Copy Markdown
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things here and there, but looking good. I'm not sure I love the class names being specific to allays, not a big deal though

Comment thread src/main/java/ch/njol/skript/conditions/CondAllayCanDuplicate.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffAllayCanDuplicate.java Outdated
Comment thread src/main/java/ch/njol/skript/expressions/ExprAllayJukebox.java Outdated
Comment thread src/main/java/ch/njol/skript/expressions/ExprDuplicateCooldown.java Outdated
Comment thread src/main/java/ch/njol/skript/expressions/ExprDuplicateCooldown.java Outdated
Comment thread src/test/skript/tests/syntaxes/expressions/ExprDuplicateCooldown.sk Outdated
Comment thread src/test/skript/tests/syntaxes/expressions/ExprDuplicateCooldown.sk
Comment thread src/main/java/ch/njol/skript/effects/EffAllayDuplicate.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffAllayDancing.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffAllayDancing.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffAllayCanDuplicate.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffAllayCanDuplicate.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffAllayDancing.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffAllayDancing.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffAllayDancing.java Outdated
Comment thread src/main/java/ch/njol/skript/expressions/ExprDuplicateCooldown.java Outdated
Comment thread src/test/skript/tests/syntaxes/expressions/ExprDuplicateCooldown.sk
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Comment thread src/main/java/ch/njol/skript/effects/EffAllayDancing.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffAllayDuplicate.java Outdated
Comment thread src/test/skript/tests/syntaxes/expressions/ExprDuplicateCooldown.sk Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffDancing.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffDancing.java Outdated
Comment thread src/test/skript/tests/syntaxes/effects/EffDancing.sk
@Absolutionism Absolutionism requested a review from a team as a code owner March 19, 2025 22:29
@Absolutionism Absolutionism requested a review from Romitou March 19, 2025 22:29
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 19, 2025
@sovdeeth sovdeeth removed the request for review from a team March 21, 2025 01:49
@erenkarakal erenkarakal merged commit de0ee5e into SkriptLang:dev/feature Mar 31, 2025
erenkarakal added a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Initial Commit

* Requested Changes

* Update CondIsDancing Desc

* Requested Changes

* Requested Changes

* Piglin Dancing

* Update EffDancing.java

---------

Co-authored-by: SirSmurfy2 <82696841+TheAbsolutionism@users.noreply.github.com>
Co-authored-by: Eren <67760502+erenkarakal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants