Skip to content

Bat Support#7362

Merged
erenkarakal merged 17 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/BatSupport
Mar 31, 2025
Merged

Bat Support#7362
erenkarakal merged 17 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/BatSupport

Conversation

@Absolutionism
Copy link
Copy Markdown
Contributor

@Absolutionism Absolutionism commented Jan 2, 2025

Description

This PR aims to add support for Bats sleeping and Sleep Toggle Event
Went ahead and added other entities capable of sleeping
Allows users to make entities goto sleep and wakeup.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the feature Pull request adding a new feature. label Jan 2, 2025
Comment thread src/main/java/ch/njol/skript/conditions/CondIsSleeping.java Outdated
Comment thread src/main/java/ch/njol/skript/conditions/CondIsSleeping.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/events/SimpleEvents.java Outdated
@Absolutionism Absolutionism requested a review from Efnilite January 2, 2025 20:25
Comment thread src/main/java/ch/njol/skript/conditions/CondIsSleeping.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/conditions/CondIsSleeping.java Outdated
Copy link
Copy Markdown
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better, but just some more stuff

Comment thread src/main/java/ch/njol/skript/conditions/CondIsSleeping.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java
Comment thread src/test/skript/tests/syntaxes/effects/EffWakeupSleep.sk
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume the description means it's fine to have locations that are unreasonable to sleep at

Comment thread src/main/java/ch/njol/skript/effects/EffWakeupSleep.java Outdated
@Absolutionism Absolutionism requested a review from a team as a code owner March 19, 2025 22:29
@Absolutionism Absolutionism requested a review from Pesekjak March 19, 2025 22:29
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 19, 2025
@sovdeeth sovdeeth removed the request for review from a team March 21, 2025 01:49
@erenkarakal erenkarakal merged commit 5f2cc81 into SkriptLang:dev/feature Mar 31, 2025
erenkarakal added a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Initial Commit

* Requested Changes

* Requested Changes

* Fix Malformed Pattern

* Requested Changes

* Runtime warning

* Update Runtime Warning

* Requested Changes

* warning update

---------

Co-authored-by: SirSmurfy2 <82696841+TheAbsolutionism@users.noreply.github.com>
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Co-authored-by: Eren <67760502+erenkarakal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants