Skip to content

EffVehicle + CondIsRiding Update#7386

Merged
sovdeeth merged 11 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/RidingUpdate
Mar 19, 2025
Merged

EffVehicle + CondIsRiding Update#7386
sovdeeth merged 11 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/RidingUpdate

Conversation

@Absolutionism
Copy link
Copy Markdown
Contributor

Description

This PR aims to fix the IllegalArgumentException when attempting to make an entity ride itself and updates CondIsRiding by allowing users to provide a specific entity to test if riding.


Target Minecraft Versions: any
Requirements: none
Related Issues: #7385

@Romitou Romitou added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 4, 2025
@cheeezburga
Copy link
Copy Markdown
Member

Feel free to add #6693 to this PR as well (remove the PassengerUtils class and update accordingly). If you think it's out of scope then don't worry.

Comment thread src/main/java/ch/njol/skript/conditions/CondIsRiding.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffVehicle.java Outdated
Comment thread src/main/java/ch/njol/skript/conditions/CondIsRiding.java
Comment thread src/main/java/ch/njol/skript/conditions/CondIsRiding.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffVehicle.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffVehicle.java
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Feb 2, 2025
@sovdeeth sovdeeth merged commit 094a23b into SkriptLang:dev/feature Mar 19, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Initial Commit

* Better Assertion Messages

* Remove PassengerUtils usage

* Requested Changes

* Change expression for mounting

* Leave Vehicle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants