Fix formatNumber() Inconsistency#7457
Closed
erenkarakal wants to merge 1 commit into
Closed
Conversation
Moderocky
added
the
breaking changes
Member
|
Can we not just adjust the tests and/or force US only during the testing environment? |
Member
Author
I don't know how you would adjust the test but we can try the |
Contributor
|
Why not Locale.ENGLISH? |
Member
Author
|
closing in favor of #7557 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some European countries such as France and Germany use
.as their thousands separator while the US uses,. This causes inconsistencies in the function output and causes tests to fail depending on the server's locale.This PR fixes this issue by forcing it to use US symbols.
Target Minecraft Versions: any
Requirements: none
Related Issues: none