Skip to content

Fiix getArray mistake in CondIsTagged, add runtime error for bad namespace keys in ExprTag#7474

Merged
APickledWalrus merged 4 commits into
SkriptLang:dev/patchfrom
sovdeeth:fix/is-tagged-all
Feb 1, 2025
Merged

Fiix getArray mistake in CondIsTagged, add runtime error for bad namespace keys in ExprTag#7474
APickledWalrus merged 4 commits into
SkriptLang:dev/patchfrom
sovdeeth:fix/is-tagged-all

Conversation

@sovdeeth

@sovdeeth sovdeeth commented Jan 18, 2025

Copy link
Copy Markdown
Member

Description

changes getArray to getAnd in CondIsTagged to fix #7471
adds runtime error to catch invalid tags in ExprTag


Target Minecraft Versions: any
Requirements: none
Related Issues: #7471

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jan 18, 2025
@sovdeeth sovdeeth changed the base branch from master to dev/patch January 18, 2025 19:15
@Efnilite Efnilite added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jan 19, 2025

@ShaneBeee ShaneBeee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things.

Comment thread src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTag.java Outdated
Comment thread src/test/skript/tests/regressions/7471-is tagged or list.sk
Comment thread src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTag.java Outdated
@APickledWalrus APickledWalrus merged commit aa19393 into SkriptLang:dev/patch Feb 1, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CondIsTagged uses getArray instead of getAll

5 participants