Goat Support#7479
Merged
Merged
Conversation
ShaneBeee
suggested changes
Jan 20, 2025
Contributor
ShaneBeee
left a comment
ShaneBeee
left a comment
There was a problem hiding this comment.
Looks good, just a few ideas about the patterns.
Efnilite
requested changes
Jan 20, 2025
Efnilite
added
the
enhancement
ShaneBeee
suggested changes
Jan 21, 2025
Contributor
ShaneBeee
left a comment
ShaneBeee
left a comment
There was a problem hiding this comment.
Looks good, just a few minor nit picks.
Also, I'm assuming no test for ram, as that'd be hard to do, but is there a reason there is no horn test?
Efnilite
requested changes
Jan 28, 2025
sovdeeth
requested changes
Feb 2, 2025
Pushing so I can pull other changes
Contributor
Author
|
@Efnilite Can you share some info on why this isn't working? Doing what you said to do. |
Efnilite
reviewed
Feb 8, 2025
Contributor
Author
|
Since it seems that the JUnit testing environment doesn't support tests that require tick(s) as well. I have commented out the |
Efnilite
approved these changes
Feb 11, 2025
sovdeeth
requested changes
Feb 16, 2025
Absolutionism
requested review from
erenkarakal
and removed request for
ShaneBeee
sovdeeth
approved these changes
Mar 21, 2025
sovdeeth
added
the
feature-ready
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Initial Commit * Ram Note * Requested Changes * Docs Update * Semi-Update Pushing so I can pull other changes * No Work * update junit tests * Void GoatHorns Test * Requested Changes * Example Annotation --------- Co-authored-by: SirSmurfy2 <82696841+TheAbsolutionism@users.noreply.github.com> Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add additional support for Goats:
Changing the horns of a goat takes a tick thus leading to no test.
Target Minecraft Versions: any
Requirements: none
Related Issues: none