Fix Invalid Equipment Slots in CondIsWearing#7525
Merged
APickledWalrus merged 9 commits intoFeb 1, 2025
Merged
Conversation
Member
Author
|
I wonder how the tests failed after I literally ran them and they succeeded.... Also the |
sovdeeth
added
the
bug
sovdeeth
approved these changes
Jan 25, 2025
cheeezburga
approved these changes
Jan 25, 2025
cheeezburga
added
the
patch-ready
Absolutionism
requested changes
Jan 25, 2025
Absolutionism
approved these changes
Jan 26, 2025
APickledWalrus
approved these changes
Feb 1, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a missing check whether an entity can use an equipment slot. For example, players cannot use the
bodyequipment slot, causing an exception when usingCondIsWearing. This was fixed by filtering the entities that can use the equipment slot inside the stream before callingEntityEquipment#getItem(EquipmentSlot)Target Minecraft Versions: any
Requirements: none
Related Issues: #7524