Skip to content

Fix cast exception when using invalid classes with CondIsTagged#7527

Merged
APickledWalrus merged 2 commits into
SkriptLang:dev/patchfrom
sovdeeth:fix/tag-class-stacktrace
Feb 1, 2025
Merged

Fix cast exception when using invalid classes with CondIsTagged#7527
APickledWalrus merged 2 commits into
SkriptLang:dev/patchfrom
sovdeeth:fix/tag-class-stacktrace

Conversation

@sovdeeth
Copy link
Copy Markdown
Member

Description

Adds a check to ensure the value and the tag are actually valid to use with isTagged(). This is honestly a pretty awkward problem and I think the solution i have is reasonable, but not ideal. Better ideas welcome.


Target Minecraft Versions: any
Requirements: none
Related Issues: #7452

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jan 25, 2025
@sovdeeth sovdeeth requested review from a team, APickledWalrus and Moderocky January 25, 2025 16:24
Copy link
Copy Markdown
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@APickledWalrus APickledWalrus added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Feb 1, 2025
@APickledWalrus APickledWalrus merged commit 382f883 into SkriptLang:dev/patch Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants