Fix loop behaviour from super call.#7537
Merged
Merged
Conversation
Moderocky
added
bug
Moderocky
requested review from
APickledWalrus,
UnderscoreTud,
cheeezburga and
sovdeeth
sovdeeth
approved these changes
Jan 26, 2025
APickledWalrus
approved these changes
Jan 26, 2025
Member
There was a problem hiding this comment.
Broadcasts can be removed
Moderocky
commented
Jan 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Fix loop behaviour from super call. * Update src/test/skript/tests/syntaxes/expressions/ExprQueue.sk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with subclasses of loop which couldn't call LoopSection's
setNextbecause it was obscured by the overriding method.This was causing triggers to terminate early (though I'm actually not sure why, it seems a bit dodgy, but this was definitely the cause). As a result, it was reporting as correct in the test system because the tests only measure for failures (and the assertions were just never being reached).
I also fixed a couple of other minor problems that had been hidden by this, since their tests were getting skipped.
Fixes #7536