RegistryParser - fix pulling from the lang file on custom entries#7540
Merged
APickledWalrus merged 3 commits intoFeb 1, 2025
Merged
Conversation
Moderocky
added
the
bug
APickledWalrus
approved these changes
Feb 1, 2025
sovdeeth
approved these changes
Feb 1, 2025
APickledWalrus
added
the
patch-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix a tiny little bug with lang nodes in the RegistryParser.
What I noticed is if the lang file contains an entry that matches a custom entry, Skript attempts to use it, when it should only use
minecraftnamespaced entries.Ex:
In the lang file under biomes, we have
desert_lakes(Im assuming an old MC biome?!?!?)When using a data pack that has
packname:desert_lakesit grabs from the lang file.This shouldn't happen.
We shouldn't be looking in the lang file for non-Minecraft entries.
The change I have implemented here was to only grab from the lang file if it's a minecraft namespaced object.
Target Minecraft Versions: any
Requirements: none
Related Issues: none