Skip to content

Update extended Property Conditions#7566

Merged
sovdeeth merged 4 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/UpdatePropertyConditions
Mar 21, 2025
Merged

Update extended Property Conditions#7566
sovdeeth merged 4 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/UpdatePropertyConditions

Conversation

@Absolutionism
Copy link
Copy Markdown
Contributor

Description

What initially started off as me adding the missing getPropertyType to the property conditions that needed it, ended leading to updating other classes to current conventions.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. housekeeping Housekeeping-related issue or task. labels Feb 2, 2025
Comment thread src/main/java/ch/njol/skript/conditions/CondIsInteractable.java Outdated
Comment thread src/main/java/ch/njol/skript/conditions/CondIsFuel.java Outdated
Comment thread src/main/java/ch/njol/skript/conditions/CondIgnitionProcess.java Outdated
Comment thread src/main/java/ch/njol/skript/conditions/CondEntityIsInLiquid.java Outdated
Comment thread src/main/java/ch/njol/skript/conditions/CondIsPassable.java Outdated
@cheeezburga cheeezburga added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Feb 5, 2025
@TheLimeGlass
Copy link
Copy Markdown
Contributor

Doesn't the new registration have a way to set parsing data? Wouldn't it be beneficial to utilize that instead of having to use the method?

@sovdeeth sovdeeth requested review from a team as code owners March 21, 2025 19:52
@sovdeeth sovdeeth requested review from UnderscoreTud and erenkarakal and removed request for a team March 21, 2025 19:52
@sovdeeth sovdeeth merged commit 526e454 into SkriptLang:dev/feature Mar 21, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Initial Commit

* Update RequiredPlugins

* Update CondIsInOpenWater.java

---------

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. housekeeping Housekeeping-related issue or task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants