Skip to content

Ghast Support#7597

Merged
Efnilite merged 5 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/GhastSupport
Mar 20, 2025
Merged

Ghast Support#7597
Efnilite merged 5 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/GhastSupport

Conversation

@Absolutionism
Copy link
Copy Markdown
Contributor

@Absolutionism Absolutionism commented Feb 8, 2025

Description

This PR aims to add support for Ghasts allowing users to check if a ghast is charging for a fireball and get+set the explosive power of ghasts.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Feb 10, 2025
sovdeeth
sovdeeth requested changes Feb 16, 2025
View reviewed changes
Comment thread src/main/java/ch/njol/skript/conditions/CondIsCharging.java Outdated
Comment thread src/test/skript/tests/syntaxes/expressions/ExprExplosiveYield.sk
@Absolutionism Absolutionism requested a review from sovdeeth March 2, 2025 17:29
sovdeeth
sovdeeth requested changes Mar 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall

Comment thread src/main/java/ch/njol/skript/expressions/ExprExplosiveYield.java Outdated
@Absolutionism Absolutionism requested a review from sovdeeth March 16, 2025 02:38
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 16, 2025
@Absolutionism Absolutionism requested a review from a team as a code owner March 19, 2025 22:33
@Efnilite Efnilite merged commit 86efdcd into SkriptLang:dev/feature Mar 20, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
@Absolutionism @Efnilite @erenkarakal
Ghast Support (SkriptLang#7597)
a5f858c 
* Initial Commit

* Requested Changes

* Float Helper Method

---------

Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Efnilite Efnilite Efnilite approved these changes

@Romitou Romitou Awaiting requested review from Romitou Romitou is a code owner automatically assigned from SkriptLang/core-developers

@Pesekjak Pesekjak Awaiting requested review from Pesekjak Pesekjak is a code owner automatically assigned from SkriptLang/core-developers

Assignees

No one assigned

Labels

enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Absolutionism @sovdeeth @Efnilite