Fix Truncation in Timespan Tabulation#7646
Merged
sovdeeth merged 3 commits intoFeb 28, 2025
Merged
Conversation
sovdeeth
added
the
bug
Member
|
Efnilite
approved these changes
Feb 25, 2025
Seems in line with existing behavior. |
erenkarakal
approved these changes
Feb 25, 2025
erenkarakal
added
the
patch-ready
Burbulinis
reviewed
Feb 25, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* switch timespan mult/div to use doubles until creating the timespan * revert to /0 equaling null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Does as much math in doubles as possible before clamping to long when creating the timespan.
Target Minecraft Versions: any
Requirements: none
Related Issues: #7645