Fishing event additions#7683
Merged
Merged
Conversation
Registers PlayerFishEvent.State as EnumClassInfo
Adds fishing state change event, fishing state EventValue
Adds fishing states
Removes accidental 0's... oops
Adds a fishing state change example
Absolutionism
requested changes
Mar 7, 2025
…le.java Co-authored-by: SirSmurfy2 <82696841+TheAbsolutionism@users.noreply.github.com>
Fixes an issue where state change pattern would not register, as its state = null
Absolutionism
approved these changes
Mar 12, 2025
Efnilite
approved these changes
Mar 12, 2025
Efnilite
added
the
enhancement
Fixes SkriptLang#7475 (adds "fishing hook" expression)
Efnilite
approved these changes
Mar 12, 2025
sovdeeth
requested review from
UnderscoreTud and
abandonedaccount6235
and removed request for
a team
Contributor
Author
Interesting, it compiled for me just fine (with no other changes), so I have no idea why it wouldn't here. |
Member
|
you forgot to import FishHook.class somewhere |
Contributor
Author
|
oops, 1 sec |
forgot an import... oops
Contributor
Author
|
There we go |
sovdeeth
approved these changes
Apr 1, 2025
sovdeeth
left a comment
sovdeeth
left a comment
Member
There was a problem hiding this comment.
looks good with pickle changes
sovdeeth
added
the
feature-ready
1 task
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds fishing state change[d] event, as well as event-fishing state EventValue, and fishing state type.
Tested on Paper 1.21.4