Fix bookshelf and decorated pot comparisons#7696
Merged
erenkarakal merged 11 commits intoMar 31, 2025
Merged
Conversation
Fusezion
commented
Mar 13, 2025
…into patch/bookshelf-inventory-type # Conflicts: # src/test/skript/tests/regressions/7620-can't-compare-bookshelf-with-block.sk
- use blockdata instead
Absolutionism
approved these changes
Mar 16, 2025
Romitou
added
the
bug
Efnilite
added
the
breaking changes
Efnilite
approved these changes
Mar 18, 2025
sovdeeth
approved these changes
Mar 22, 2025
sovdeeth
added
the
feature-ready
Fusezion
requested review from
APickledWalrus and
Romitou
and removed request for
a team
erenkarakal
added a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Fix bookshelf and decorated pot comparisons * newline ;( * lazy fix * Fix forgotten test change * 100% fix intentional design, or something - use blockdata instead * Fix the test that I somehow broke --------- Co-authored-by: Eren <67760502+erenkarakal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the issue mentioned in #7620, this pr makes the inventory types of
chiseled bookshelfanddecorated potuse the same pattern as all other inventory types of[chiseled] bookshelf inventoryanddecorated pot inventorythis is technically a breaking change, however past behavior make things like
target block of x is ynearly impossible to do without janky work arounds like"bookshelf" parsed as itemtypeUnsure how needed the regression test is but since this was a bug, I've gone ahead and added one, this targets dev/feature since it's the next planned release.
Target Minecraft Versions: any 1.20+ for decorated pots
Requirements: none
Related Issues: none #7620