Skip to content

Add ExprAnyOf and fix bug with setting or lists#7701

Merged
sovdeeth merged 5 commits into
SkriptLang:dev/featurefrom
sovdeeth:feature/any-of
Mar 21, 2025
Merged

Add ExprAnyOf and fix bug with setting or lists#7701
sovdeeth merged 5 commits into
SkriptLang:dev/featurefrom
sovdeeth:feature/any-of

Conversation

@sovdeeth
Copy link
Copy Markdown
Member

Description

Adds ExprAnyOf, which converts any list given to it into an OR list. (if any of {a::*} are within {loc1} and {loc2})
Fixes an issue where setting an OR list would treat it like changing an AND list (set {a} or {b} to 1 would set both)


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. feature Pull request adding a new feature. labels Mar 14, 2025
@sovdeeth sovdeeth requested a review from a team March 14, 2025 19:02
@sovdeeth sovdeeth requested a review from a team March 15, 2025 16:07
@sovdeeth
Copy link
Copy Markdown
Member Author

@Efnilite you jerk lol

@sovdeeth sovdeeth requested review from a team, APickledWalrus and abandonedaccount6235 and removed request for a team March 17, 2025 22:58
@Efnilite
Copy link
Copy Markdown
Member

does it approve for the whole team? lol

@sovdeeth
Copy link
Copy Markdown
Member Author

does it approve for the whole team? lol

yeah any member's review counts and you bloody did it twice

Copy link
Copy Markdown
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment thread src/main/java/ch/njol/skript/expressions/ExprAnyOf.java Outdated
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 17, 2025
@sovdeeth sovdeeth requested a review from a team as a code owner March 21, 2025 20:44
@sovdeeth sovdeeth requested review from UnderscoreTud and removed request for a team March 21, 2025 20:44
@sovdeeth sovdeeth merged commit 4e30b29 into SkriptLang:dev/feature Mar 21, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* implement ExprAnyOf + expressionlist bug fix

* optimize imports

* Update ExprAnyOf.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants