Add entity size expression#7702
Merged
erenkarakal merged 16 commits intoMar 31, 2025
Merged
Conversation
Efnilite
requested changes
Mar 15, 2025
Member
Efnilite
left a comment
Efnilite
left a comment
There was a problem hiding this comment.
needs tests for adding/removing/setting infs and nans and for removing that it becomes below 0
abandonedaccount6235
previously requested changes
Mar 15, 2025
Handle documentation changes Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Absolutionism
approved these changes
Mar 16, 2025
Co-authored-by: SirSmurfy2 <82696841+TheAbsolutionism@users.noreply.github.com>
Efnilite
approved these changes
Mar 16, 2025
Burbulinis
approved these changes
Mar 17, 2025
sovdeeth
requested changes
Mar 22, 2025
Whoops Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
approved these changes
Mar 23, 2025
sovdeeth
added
the
feature-ready
erenkarakal
added a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* ExprEntitySize - Add entity size for slimes and phantoms * ExprEntitySize - Add null and nan to test * ExprEntitySize - Follow nbt format for slimes * ExprEntitySize.java - description change * Apply suggestions from code review Handle documentation changes Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com> * ExprEntitySize.java - deltaSize * ExprEntitySize.java - Fix integer overflow * ExprEntitySize.sk - Expand test cases * ExprEntitySize.java - deltaSize -> sizeDelta * "I" Helped Co-authored-by: SirSmurfy2 <82696841+TheAbsolutionism@users.noreply.github.com> * Update src/main/java/ch/njol/skript/expressions/ExprEntitySize.java Whoops Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com> * ExprEntitySize.java - Update description to include default sizes --------- Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com> Co-authored-by: SirSmurfy2 <82696841+TheAbsolutionism@users.noreply.github.com> Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com> Co-authored-by: Eren <67760502+erenkarakal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a new expression for changing and getting the sizes of slimes and phantoms, this is not the same as changing attribute scale, slimes when changed will have changes done to their attributes for health, attack damage, and movement speed.
I've decided to fully prevent infinity and NaN values due to poorly defined behavior. When setting a value to NaN before would cause the value to be reset compared to setting it to null will do nothing, as a means to retain parity this was decided upon.
Any feedback regarding the description or test is welcomed they all seem to run fine and the same goes for ingame. As for why I didn't use
with ""or whatever it was is to keep messages readable if errors appear, this relies more on the expected but got error.Target Minecraft Versions: any
Requirements: none
Related Issues: none