ExprTool - Cleanup & Additional Test

[Fusezion]

Description

This PR aims to clean up the ExprTool class as well as include some more test for it.
The patterns have been split to hopefully increase readability of the pattern itself making it clear what is what.
Additionally a new method to the BukkitUtils class has been added to get equipment slot from their indices as well as the indices of the slots themselves.

I will say the handling of the events in this expression does not make any sense to happen, these should have been event-values, however it's sadly too late to change them.

---

Target Minecraft Versions: any
Requirements: none
Related Issues: #5700

[sovdeeth]

I'm a little apprehensive about using just main hand and off hand for this. There has been prior conversation (i don't think it went anywhere) about being able to detect which hand was used in a click event and using main hand and off hand as ways to differentiate the two. Do you think it's worth keeping those patterns unused for possible future use and still requiring tool/item? If we don't, it'll make any future reassignment a breaking change.

I personally think that tool/item should remain required as this expression is specifically about the item, not the hand itself.

[Fusezion]

I'm a little apprehensive about using just main hand and off hand for this. There has been prior conversation (i don't think it went anywhere) about being able to detect which hand was used in a click event and using main hand and off hand as ways to differentiate the two.

I wouldn't see why the team would want to make a whole new comparison for handling that in click when it would likely be much easier to add an event-value for click type with left/right mouse button.

Do you think it's worth keeping those patterns unused for possible future use and still requiring tool/item? If we don't, it'll make any future reassignment a breaking change.

I'm still not too sure on changing it, main hand of %entity% makes sense howevr mainhand item/tool of %entity% doesn't
offhand tool/item, I can revert the change but mainhand doesn't really have a good counter part

[sovdeeth]

I wouldn't see why the team would want to make a whole new comparison for handling that in click when it would likely be much easier to add an event-value for click type with left/right mouse button.

Using main/offhand isn't the same as left/right click. If you're holding a sword in the main hand, torch in the offhand, and you click place, it will use the offhand. But if the sword has a block component or whatever, it'll block with the sword. It's not that simple,

I'm still not too sure on changing it, main hand of %entity% makes sense howevr mainhand item/tool of %entity% doesn't
offhand tool/item, I can revert the change but mainhand doesn't really have a good counter part

Well, you just do [main hand] (tool|weapon...). I also don't think we should be allowing mainhand. We shouldn't really be allowing offhand either, but that ship already sailed.

[Fusezion]

I've updated this PR to remove the option of main hand of %entity% and off hand of %entity% and am now just marking it as a class cleanup.

There's only one part in this that confuses me and leads to improper behavior