Literal Class Info Parsing

[Absolutionism]

Description

Problem

There are many literals in Skript that share the same name, like unknown, which is used for at least 8 different things. This can cause issues when Skript isn't given enough context, like set {_x} to black. Should it be a wolf variant or a color?

Solution

This pr attempts to solve that by introducing a method of clarification after the literal: black (wolf color) or black (color). This is not meant to replace the current system of unparsed literals and attempting re-parses, but to work alongside it and allow users to specify exactly what they mean if they do encounter issues.

How It Works

During literal parsing, the input is checked against a regex pattern to see if the user supplied a clarifying type. If so, only that classinfo's parser is attempted instead of trying all possible parsers. If the clarifying type doesn't match the target type, we can simply exit, which is earlier than if all parsers had to be attempted.

Any Possible Risks/Benefits

This should help improve the experience of users dealing with ambiguous literals and allow them to write more consistent, readable code. The format of literal (classinfo) isn't set in stone, but from discussion it seemed to fit best as a point of clarification within a sentence, like "She went to that bar (Elmsworth's) down on Main Street". Testing is needed to ensure this doesn't conflict with any existing syntax, though I cannot think of any cases off the top of my head. Functions might be the closest, but those should not permit a space between the name and the (.

---

Target Minecraft Versions: any
Requirements: none
Related Issues: #7589

[Burbulinis]

lgtm, just tests for the errors

[abandonedaccount6235]

if it's not already possible, can you run the type through Noun#stripIndefiniteArticle so that users can do black (the wolf color)? I honestly envisioned the syntax as always being used with "the", but I'm not sure if it makes sense to actually enforce requiring it. I think including the makes it fit much better but I'm not sure if it should actually be required.

[abandonedaccount6235]

perhaps we could call these "clarified literals" and "literal clarification"

[Absolutionism]

if it's not already possible, can you run the type through Noun#stripIndefiniteArticle so that users can do black (the wolf color)? I honestly envisioned the syntax as always being used with "the", but I'm not sure if it makes sense to actually enforce requiring it. I think including the makes it fit much better but I'm not sure if it should actually be required.

Seems that Noun#stripIndefiniteArticle only removes a and an
the is stored as a definite article, and I dont see a method to remove that, should I add one?

[sovdeeth]

Note that the classinfo parser already handles stripping indefinite articles

[abandonedaccount6235]

code looks good, thanks! i'd like to wait for some additional team member input over the next few weeks before we merge :)

[abandonedaccount6235]

I would also like to agree upon a name for this functionality before we merge

[sovdeeth]

I would also like to agree upon a name for this functionality before we merge

literal type clarification

[ShaneBeee]

I would also like to agree upon a name for this functionality before we merge

In all fairness, what does it matter? This doesn't appear to be documented.
You're asking to agree upon a name, but for what reason?
Where exactly is the naming being worried about?

If you want people to agree up on a name, you should include your reasoning as to WHY it should be agreed upon, other than for personal reasons.

Its common knowledge that SkriptLang lacks in communication, and this response is a great example of just that.