Bell Events Registering+Test Update#7762
Merged
APickledWalrus merged 3 commits intoApr 1, 2025
Merged
Conversation
Absolutionism
requested review from
erenkarakal and
sovdeeth
and removed request for
a team
Efnilite
approved these changes
Apr 1, 2025
Efnilite
added
the
enhancement
APickledWalrus
approved these changes
Apr 1, 2025
sovdeeth
approved these changes
Apr 1, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per Skript 2.10, the lowest supported server version was capped at 1.19.4
This PR updates when registering the
BellRingEventas Paper had added it in 1.16.5 and it was not added into Spigot until 1.19.4, thus removing the checks in order to register the event.While we're here, remove the check for
BellResonateEventwhen registeringAnd ultimately, updating the test to only be contained within 1 file, removing the need to have 2 disabled files, and having to load+unload them.
Which helps with any future PRs in development that end up failing or bricking the JUnit testing environment, causing the files that needed to be disabled, not get disabled. (locally)
Target Minecraft Versions: any
Requirements: none
Related Issues: none