Skip to content

Fix double-claiming behavior with Secspressions that have no section.#7773

Merged
sovdeeth merged 1 commit into
SkriptLang:dev/featurefrom
sovdeeth:fix/exprsec-double-claim
Apr 7, 2025
Merged

Fix double-claiming behavior with Secspressions that have no section.#7773
sovdeeth merged 1 commit into
SkriptLang:dev/featurefrom
sovdeeth:fix/exprsec-double-claim

Conversation

@sovdeeth
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth commented Apr 4, 2025

Description

The sectioncontext was not being cleared when attempting to parse sectionless statements, which resulted in sectionless Secspressions being given their parent section to claim, leading to shenanigans like the secspression parsing itself multiple times.

This ensures the section context is cleared before attempting to parse sectionless statements.


Target Minecraft Versions: any
Requirements: none
Related Issues: #7721

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Apr 4, 2025
@sovdeeth sovdeeth requested a review from Moderocky April 4, 2025 23:01
@sovdeeth sovdeeth requested review from a team as code owners April 4, 2025 23:01
@sovdeeth sovdeeth requested review from Pesekjak and removed request for a team April 4, 2025 23:01
Copy link
Copy Markdown
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay to me

@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Apr 6, 2025
@sovdeeth sovdeeth merged commit 6f2211f into SkriptLang:dev/feature Apr 7, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants