Skip to content

Fixes armor change NoClassDefFound error on Spigot #7774

Merged
sovdeeth merged 2 commits into
SkriptLang:dev/featurefrom
sovdeeth:fix/ncdf-armor-spigot
Apr 7, 2025
Merged

Fixes armor change NoClassDefFound error on Spigot #7774
sovdeeth merged 2 commits into
SkriptLang:dev/featurefrom
sovdeeth:fix/ncdf-armor-spigot

Conversation

@sovdeeth
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth commented Apr 5, 2025

Description

References to the SlotType enum in switch statements forced the enum to be loaded on Spigot servers, causing an error.
This switches to a map and Enum.valueOf to prevent loading SlotType unless needed.
Also cleans up some logic in the class.


Target Minecraft Versions: any
Requirements: none
Related Issues: #7771

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Apr 5, 2025
@sovdeeth sovdeeth requested a review from a team as a code owner April 5, 2025 00:42
@sovdeeth sovdeeth requested review from UnderscoreTud and abandonedaccount6235 and removed request for a team April 5, 2025 00:42
@Efnilite Efnilite added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Apr 6, 2025
@sovdeeth sovdeeth merged commit 1201194 into SkriptLang:dev/feature Apr 7, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants