Skip to content

Adds missing lang entries for bundle inventory actions and bucket spawn reason#7776

Merged
sovdeeth merged 2 commits into
SkriptLang:dev/featurefrom
sovdeeth:fix/missing-bundle-actions
Apr 7, 2025
Merged

Adds missing lang entries for bundle inventory actions and bucket spawn reason#7776
sovdeeth merged 2 commits into
SkriptLang:dev/featurefrom
sovdeeth:fix/missing-bundle-actions

Conversation

@sovdeeth
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth commented Apr 5, 2025

Description

Adds lang entries for 1.21.4+ bundle inventory actions (These actions appear to be unused as of Paper 1.21.4-222).
Adds entry for bucket spawn reason. Due to conflicts, I chose release from bucket as the full entry. Suggestions welcome.


Target Minecraft Versions: any
Requirements: none
Related Issues: #7772

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Apr 5, 2025
@sovdeeth sovdeeth requested a review from a team as a code owner April 5, 2025 01:34
@sovdeeth sovdeeth requested review from Efnilite and cheeezburga and removed request for a team April 5, 2025 01:34
@ShaneBeee
Copy link
Copy Markdown
Contributor

(These actions appear to be unused as of Paper 1.21.4-222).

Curious what you meant by this?

@sovdeeth
Copy link
Copy Markdown
Member Author

sovdeeth commented Apr 5, 2025

(These actions appear to be unused as of Paper 1.21.4-222).

Curious what you meant by this?

getAction seems to always return PLACE_ALL from my testing

my bad i committed the cardinal sin of testing ICE in creative lmao

@ShaneBeee
Copy link
Copy Markdown
Contributor

(These actions appear to be unused as of Paper 1.21.4-222).

Curious what you meant by this?

getAction seems to always return PLACE_ALL from my testing

my bad i committed the cardinal sin of testing ICE in creative lmao

yeah I was about to say. I filed the issue because of a convo on paper, and yeah in creative it just shows PLACE_ALL

@sovdeeth sovdeeth changed the title Adds missing lang entries for bundle inventory actions and bucket spawn reason` Adds missing lang entries for bundle inventory actions and bucket spawn reason Apr 5, 2025
bed: bed
beehive: beehive
breeding: breed, breeding
bucket: release from bucket # 'bucket' alone is problematic
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Apr 6, 2025
@sovdeeth sovdeeth merged commit 43dee01 into SkriptLang:dev/feature Apr 7, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
…wn reason (SkriptLang#7776)

adds bundle actions and bucket spawn reason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants