Skip to content

Use the gradle properties for the latest environment reference#7797

Merged
Absolutionism merged 5 commits intoSkriptLang:dev/featurefrom
TheLimeGlass:feature/use-properties-latest-reference
Sep 18, 2025
Merged

Use the gradle properties for the latest environment reference#7797
Absolutionism merged 5 commits intoSkriptLang:dev/featurefrom
TheLimeGlass:feature/use-properties-latest-reference

Conversation

@TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Apr 13, 2025

Description

Use the gradle properties for the latest environment reference so you don't have to remember to maintain it each version bump.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TheLimeGlass TheLimeGlass requested a review from a team as a code owner April 13, 2025 09:34
@TheLimeGlass TheLimeGlass requested review from Romitou and sovdeeth and removed request for a team April 13, 2025 09:34
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also adjust line 269 as well

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Apr 16, 2025
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label May 15, 2025
@TheLimeGlass
Copy link
Contributor Author

should also adjust line 269 as well

To what? It's already referencing the file?

@TheLimeGlass TheLimeGlass requested a review from sovdeeth July 1, 2025 01:32
@sovdeeth
Copy link
Member

sovdeeth commented Jul 1, 2025

This change makes env identical to latestEnv, so env should be removed and references replaced with latestEnv
Actually latestEnv is not necessarily the latest anymore, so it should just replace env directly.

String env = project.testEnv + ".json";

@TheLimeGlass
Copy link
Contributor Author

This change makes env identical to latestEnv, so env should be removed and references replaced with latestEnv Actually latestEnv is not necessarily the latest anymore, so it should just replace env directly.

String env = project.testEnv + ".json";

Okay, I see what you mean.

@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Sep 18, 2025
@Absolutionism Absolutionism moved this to Awaiting Merge in 2.13 Releases Sep 18, 2025
@Absolutionism Absolutionism merged commit bcaa8c2 into SkriptLang:dev/feature Sep 18, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Sep 18, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Sep 18, 2025
@TheLimeGlass TheLimeGlass deleted the feature/use-properties-latest-reference branch October 2, 2025 08:06
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Oct 15, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
…tLang#7797)

* use the gradle properties for the latest environment reference

* Update build.gradle
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
…tLang#7797)

* use the gradle properties for the latest environment reference

* Update build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Projects

No open projects
Status: Done - Released

Development

Successfully merging this pull request may close these issues.

3 participants

Comments