Skip to content

Clarify Create Virtual WorldBorder docs and behavior#7838

Merged
APickledWalrus merged 9 commits into
SkriptLang:dev/patchfrom
ahmadmsaleem:master
May 1, 2025
Merged

Clarify Create Virtual WorldBorder docs and behavior#7838
APickledWalrus merged 9 commits into
SkriptLang:dev/patchfrom
ahmadmsaleem:master

Conversation

@ahmadmsaleem
Copy link
Copy Markdown
Contributor

While working with ExprSecCreateWorldBorder, I found the original documentation and behavior very confusing. It was unclear how virtual worldborders should be used, and setting them up properly for players

Description


Target Minecraft Versions: any
Requirements: none
Related Issues: none

While working with ExprSecCreateWorldBorder, I found the original documentation and behavior very confusing. 
It was unclear how virtual worldborders should be used, and setting them up properly for players
@ahmadmsaleem ahmadmsaleem requested a review from a team as a code owner April 28, 2025 00:25
@ahmadmsaleem ahmadmsaleem requested review from Efnilite and sovdeeth and removed request for a team April 28, 2025 00:25
Comment thread src/main/java/ch/njol/skript/expressions/ExprSecCreateWorldBorder.java Outdated
Comment thread src/main/java/ch/njol/skript/expressions/ExprSecCreateWorldBorder.java Outdated
@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. documentation Related to Skript's official documentation. labels Apr 28, 2025
Comment thread src/main/java/ch/njol/skript/expressions/ExprSecCreateWorldBorder.java Outdated
@erenkarakal
Copy link
Copy Markdown
Member

you need to create a new branch with dev/patch as the upstream branch and make your changes there

Comment thread src/main/java/ch/njol/skript/expressions/ExprSecCreateWorldBorder.java Outdated
@sovdeeth sovdeeth changed the base branch from master to dev/patch April 28, 2025 00:59
Copy link
Copy Markdown
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failing

@ahmadmsaleem ahmadmsaleem requested a review from Efnilite April 28, 2025 15:01
@Efnilite Efnilite added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Apr 29, 2025
Comment thread src/main/java/ch/njol/skript/expressions/ExprSecCreateWorldBorder.java Outdated
@APickledWalrus APickledWalrus merged commit eea1fcd into SkriptLang:dev/patch May 1, 2025
5 checks passed
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to Skript's official documentation. enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants