Conversation
src/main/java/ch/njol/skript/expressions/ExprCenterLocations.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCenterLocations.java
Outdated
Show resolved
Hide resolved
|
Just going to throw my 2 cents in here. Skript should focus on the language and the Bukkit API itself. Skript shouldn't be putting on focus on doing math that a Skript user could do themselves. Again, I repeat, just my opinion. |
|
I'm kind of ambivalent on this, since it seems like a really easy thing to do with existing tools. It's a bit clunky since you have to get a vector or do math on x/y/z, though, so i see the appeal of a simpler manner. I don't mind it either way. That said, I'm strongly against calling it the center point. I think that muddles the waters between the existing center expression (and could cause syntax conflicts as is currently written). I would stick entirely to the term I'd like to comment that the pr template does ask you to argue why the given problem needs solving, and I think just the fact that no QOL expression exists is not reason enough. I'd like to see some arguments as to why it needs to be added and why it's better than whatever you can currently do. This is also missing any documentation of testing completed. |
|
So you want only |
well |
src/main/java/ch/njol/skript/expressions/ExprMidpointLocations.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprMidpointLocations.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprMidpointLocations.java
Outdated
Show resolved
Hide resolved
|
checks failing |
* Initial Commit * Update ExprCenterLocations.sk * Update ExprCenterLocations.java * Requested Changes * Update ExprMidpointLocations.java * Allow Vectors * Test + Error Update * Update ExprMidpoint.java * Update ExprMidpoint.java * Update ExprMidpoint.java * Runtime Errors
* Initial Commit * Update ExprCenterLocations.sk * Update ExprCenterLocations.java * Requested Changes * Update ExprMidpointLocations.java * Allow Vectors * Test + Error Update * Update ExprMidpoint.java * Update ExprMidpoint.java * Update ExprMidpoint.java * Runtime Errors
Problem
Currently is no quick and easy route of getting the center location from two locations.
The only current way I know to achieve this, is
set {_center} to {_loc1} ~ ((vector from {_loc1} to {_loc2}) / vector(2,2,2))Solution
Adds
ExprMidpointthat does this.Testing Completed
ExprMidpoint.skCompletes: none
Related: none