Skip to content

Make has potion effect types optional#8010

Merged
APickledWalrus merged 8 commits intoSkriptLang:dev/patchfrom
TheLimeGlass:changes/has-potion-effects
Jul 25, 2025
Merged

Make has potion effect types optional#8010
APickledWalrus merged 8 commits intoSkriptLang:dev/patchfrom
TheLimeGlass:changes/has-potion-effects

Conversation

@TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Jul 5, 2025

Problem

User came into the skript help expecting syntax player has potion effects to be valid

Solution

Make has potion effect types optional

@TheLimeGlass TheLimeGlass requested a review from a team as a code owner July 5, 2025 15:35
@TheLimeGlass TheLimeGlass requested review from cheeezburga and erenkarakal and removed request for a team July 5, 2025 15:35
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 5, 2025
@Absolutionism Absolutionism added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jul 5, 2025
@Absolutionism Absolutionism moved this to In Review in 2.13 Releases Jul 5, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jul 5, 2025
@TheLimeGlass TheLimeGlass requested a review from Efnilite July 5, 2025 22:27
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jul 5, 2025
@sovdeeth sovdeeth removed this from 2.13 Releases Jul 15, 2025
@sovdeeth sovdeeth changed the base branch from dev/feature to dev/patch July 16, 2025 04:27
@sovdeeth sovdeeth added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Jul 16, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.12 Releases Jul 17, 2025
@APickledWalrus APickledWalrus merged commit 2d8f8eb into SkriptLang:dev/patch Jul 25, 2025
5 checks passed
@skriptlang-automation skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jul 25, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.12 Releases Jul 25, 2025
@skriptlang-automation skriptlang-automation bot removed the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jul 25, 2025
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.12 Releases Aug 1, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Projects

No open projects
Status: Done - Released

Development

Successfully merging this pull request may close these issues.

5 participants

Comments