Fix expression section claim releasing#8082
Merged
APickledWalrus merged 3 commits intoSkriptLang:dev/patchfrom Jul 25, 2025
Merged
Fix expression section claim releasing#8082APickledWalrus merged 3 commits intoSkriptLang:dev/patchfrom
APickledWalrus merged 3 commits intoSkriptLang:dev/patchfrom
Conversation
APickledWalrus
added
the
bug
APickledWalrus
requested review from
UnderscoreTud and
erenkarakal
and removed request for
a team
sovdeeth
approved these changes
Jul 25, 2025
Absolutionism
approved these changes
Jul 25, 2025
UnderscoreTud
approved these changes
Jul 25, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Releases
skriptlang-automation
bot
added
the
patch-ready
skriptlang-automation
bot
added
the
completed
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.12 Releases
skriptlang-automation
bot
removed
the
patch-ready
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When parsing a statement, if it contained a section expression, and that section expression successfully parsed and claimed a section (but the statement itself failed in init), the claim on the section would not be released. As a result, any future attempts to parse a section expression would fail as it believed the section to already be claimed.
Solution
When a section expression may be parsed, the Statement iterator is wrapped such that the "owner" of the section context is cleared when the next element of the iterator is returned.
Testing Completed
tested in game using a combination of addons that exposed the issue. testing is a bit complex as it would require usage of priorities which isn't currently possible with test syntax. if it is really wanted i can probably make it happen
Supporting Information
Completes: none
Related: none