catch rounding edge cases#8087
Merged
APickledWalrus merged 3 commits intoSkriptLang:dev/patchfrom Jul 30, 2025
Merged
Conversation
sovdeeth
requested review from
Efnilite and
cheeezburga
and removed request for
a team
sovdeeth
added
the
bug
skriptlang-automation
bot
added
the
needs reviews
1 task
APickledWalrus
approved these changes
Jul 25, 2025
Pesekjak
approved these changes
Jul 26, 2025
github-project-automation
bot
moved this from In Progress
to Awaiting Merge
in 2.12 Releases
skriptlang-automation
bot
added
patch-ready
Efnilite
approved these changes
Jul 30, 2025
skriptlang-automation
bot
added
the
completed
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.12 Releases
skriptlang-automation
bot
removed
the
patch-ready
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#8085 showed using NaN can cause issues with the round function.
Solution
I've added checks for non-finite inputs and return either the value if the value was non-finite, or NaN if the placement was too large for BigInt to handle.
Testing Completed
Added a regression test.
Supporting Information
Completes: #8085
Related: none