PatternElement Combinations + Conflicts Test#8138
Merged
sovdeeth merged 24 commits intoSkriptLang:dev/featurefrom Sep 21, 2025
Merged
PatternElement Combinations + Conflicts Test#8138sovdeeth merged 24 commits intoSkriptLang:dev/featurefrom
sovdeeth merged 24 commits intoSkriptLang:dev/featurefrom
Conversation
Efnilite
requested changes
Aug 19, 2025
Member
Efnilite
left a comment
There was a problem hiding this comment.
missing docs on all the methods. especially init should have a very clear overview of what happens. see the function rework's FunctionArgumentParser for an example
great addition 🔥
src/test/java/org/skriptlang/skript/test/tests/lang/PatternParserTest.java
Outdated
Show resolved
Hide resolved
Efnilite
reviewed
Aug 19, 2025
src/test/java/org/skriptlang/skript/test/tests/lang/PatternParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/test/tests/lang/PatternParserTest.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Aug 20, 2025
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Aug 20, 2025
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
sovdeeth
reviewed
Aug 21, 2025
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Aug 21, 2025
Efnilite
requested changes
Aug 22, 2025
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
APickledWalrus
approved these changes
Sep 18, 2025
Efnilite
approved these changes
Sep 20, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Create PatternConflictsTest.java * Draft * Update * Update PatternParserTest.java * Revert * Update PatternParserTest.java * Update PatternParserTest.java * Filtering + Exclusions * PatternElement Usage * Fix TypePatternElement * Partial Changes * Update PatternConflictsTest.java * Update PatternConflictsTest.java * Update PatternConflictsTest.java * Update PatternConflictsTest.java * Requested Changes * Pickles Changes
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Create PatternConflictsTest.java * Draft * Update * Update PatternParserTest.java * Revert * Update PatternParserTest.java * Update PatternParserTest.java * Filtering + Exclusions * PatternElement Usage * Fix TypePatternElement * Partial Changes * Update PatternConflictsTest.java * Update PatternConflictsTest.java * Update PatternConflictsTest.java * Update PatternConflictsTest.java * Requested Changes * Pickles Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As Skript progresses further, adding more elements and patterns, ensuring minimal pattern conflictions can become increasingly harder to maintain with each new pattern added.
Solution
Adds
getAllCombinationsandabstract getCombinationstoPatternElementto construct all possible combinations that can match.Adds JUnit
PatternConflictsTestensuringgetAllCombinationscorrectly operates with manual inserted patterns and combinations.Additionally, this JUnit will go through every single registered element and it's patterns to construct all combinations, store them and check if a combination can be used for more than one element/pattern.
Testing Completed
JUnit
Supporting Information
TODO:
Some form of exclusionif only x and y then excludeas can be seen withExprScriptsOldandExprScriptssince only one can be usable at a time due to experiment enabling.Categorize the elements, so patterns used inStructures don't get marked as conflictions withExpressions orEffectsCompletes: none
Related: none