Merged
Conversation
Absolutionism
approved these changes
Aug 27, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Testing in the addon development channel has revealed an issue when attempting to manually parse expressions, often as parts of sections or structures. The core issue is the inability for an addon to update SectionContext and tell the parser what section it's parsing. This manifests in different ways depending on the use case. In SkCheese, an infinite parsing loop can be created with the
new stringexpression section where not updating the SectionNode in SectionContext leads to the same Node being parsed again and again, but always being given its parent node in init(). In Oopsk, it can manifest where a field in a struct instance section containing a section expression claims its parent section leading to a double-claim. In Jake's unreleased packet addon, it leads to a strange error where a nested section using an EntryValidator is given the wrong SectionNode and claims itself is an unexpected entry.Solution
Makes SectionContext and SectionContext#modify() public for addon use.
Testing Completed
None, no logic change was made.
Supporting Information
Relevant conversation: https://discord.com/channels/135877399391764480/836696328796897340/1409833163143905361
Completes: none
Related: none