Skip to content

ExprInput Fix#8164

Merged
sovdeeth merged 1 commit intoSkriptLang:dev/patchfrom
Absolutionism:dev/ExprInput-Types-Fix
Aug 29, 2025
Merged

ExprInput Fix#8164
sovdeeth merged 1 commit intoSkriptLang:dev/patchfrom
Absolutionism:dev/ExprInput-Types-Fix

Conversation

@Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Aug 28, 2025

Problem

When specifying a type for ExprInput via %*classinfo% input, the returned array from #get was not of the specified type due to types only containing Object.class.
Thus causing a ClassCastException when being used as a typed array parameter/variable.

Solution

When a type is specified, the types field is updated to accommodate the type.

Testing Completed

ExprFilter.sk

Manual:

function get() :: offlineplayers:
	return offline players

command /fail:
	trigger:
		send title "<#00ff00>&lExample" with subtitle "%get() where [gamemode of player input is survival]%" to all players
idea64_H5k7pM2E8o.mp4

Supporting Information

N/A


Completes: #8163
Related: none

@Absolutionism Absolutionism requested a review from a team as a code owner August 28, 2025 21:36
@Absolutionism Absolutionism requested review from cheeezburga and erenkarakal and removed request for a team August 28, 2025 21:36
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Aug 28, 2025
@Absolutionism Absolutionism linked an issue Aug 28, 2025 that may be closed by this pull request
1 task
@Absolutionism Absolutionism moved this to In Review in 2.12 Releases Aug 28, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.12 Releases Aug 28, 2025
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Aug 28, 2025
@sovdeeth sovdeeth merged commit 148aed8 into SkriptLang:dev/patch Aug 29, 2025
5 checks passed
@skriptlang-automation skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Aug 29, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.12 Releases Aug 29, 2025
@skriptlang-automation skriptlang-automation bot removed the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Aug 29, 2025
@Absolutionism Absolutionism moved this from Done - Awaiting Release to Done - Released in 2.12 Releases Sep 2, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

No open projects
Status: Done - Released

Development

Successfully merging this pull request may close these issues.

ExprGameMode ClassCastException exception

3 participants

Comments