Skip to content

Use @Example annotations instead of @Examples#8224

Merged
sovdeeth merged 16 commits intoSkriptLang:dev/patchfrom
bluelhf:dev/examples-migration
Dec 31, 2025
Merged

Use @Example annotations instead of @Examples#8224
sovdeeth merged 16 commits intoSkriptLang:dev/patchfrom
bluelhf:dev/examples-migration

Conversation

@bluelhf
Copy link
Contributor

@bluelhf bluelhf commented Oct 3, 2025

Previously at #8222, closed because PR was ahead base.

This PR moves many syntaxes to use @Example-annotations instead of @Examples. The goal of this PR is to move all Skript syntaxes towards the new repeatable annotations. This results in cleaner generated JSON, with unambiguous data when multiple examples are present.

Warning

This pull request was, due to its scale and simplicity, made in large part using agentic Copilot. Copilot has proven to be quite bad at tasks like programming and understanding language, and mistakes are expected.

Testing Completed

I have generated the docs and looked for errors as well as verified every example by hand.

Note about line endings

End-of-line characters are not present when examples are defined in a single line. We should consider adapting JSONGenerator to insert an end-of-line character at the end of each example if it is missing. This way, all examples consist of POSIX-compliant 'lines', which always end in an end-of-line character.

State of pull request

@bluelhf bluelhf marked this pull request as ready for review October 19, 2025 00:21
@bluelhf bluelhf requested review from a team and UnderscoreTud as code owners October 19, 2025 00:21
@bluelhf bluelhf requested review from Absolutionism and removed request for a team October 19, 2025 00:21
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only looked through conditions

…o Example

this changes the rest of the vanilla Skript syntaxes. the old Examples annotation is left there because addons probably use it still
@bluelhf bluelhf force-pushed the dev/examples-migration branch from 96dcf0f to 332d649 Compare October 19, 2025 00:51
thanks, sovde !

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@bluelhf bluelhf requested a review from sovdeeth October 19, 2025 01:24
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

400/681

Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

555/680

@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Oct 19, 2025
applies changes from code review

Co-authored-by: sovde <10354869+sovdeeth@users.noreply.github.com>
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

680/680!

Co-authored-by: sovde <10354869+sovdeeth@users.noreply.github.com>
@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. documentation Related to Skript's official documentation. labels Oct 19, 2025
@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Dec 10, 2025
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it didn't let me suggest sometimes

@skriptlang-automation skriptlang-automation bot added needs reviews A PR that needs additional reviews and removed needs reviews A PR that needs additional reviews labels Dec 19, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Dec 28, 2025
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@skriptlang-automation skriptlang-automation bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Dec 29, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Dec 29, 2025
@sovdeeth sovdeeth merged commit f969563 into SkriptLang:dev/patch Dec 31, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Dec 31, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Dec 31, 2025
@bluelhf bluelhf deleted the dev/examples-migration branch December 31, 2025 22:13
@APickledWalrus APickledWalrus moved this from Done - Awaiting Release to Done - Released in 2.14 Releases Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. documentation Related to Skript's official documentation. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Projects

Status: Done - Released

Development

Successfully merging this pull request may close these issues.

3 participants

Comments