Skip to content

Fix brew event pattern#8284

Merged
sovdeeth merged 3 commits intoSkriptLang:dev/patchfrom
erenkarakal:feature/fix-brew-event-pattern
Dec 2, 2025
Merged

Fix brew event pattern#8284
sovdeeth merged 3 commits intoSkriptLang:dev/patchfrom
erenkarakal:feature/fix-brew-event-pattern

Conversation

@erenkarakal
Copy link
Member

@erenkarakal erenkarakal commented Nov 13, 2025

Problem

on brew complete isn't valid, but on brew complet is

Solution

Edited the pattern

Testing Completed

-

Supporting Information

Completes: none
Related: none

@erenkarakal erenkarakal requested a review from a team as a code owner November 13, 2025 17:44
@erenkarakal erenkarakal requested review from Pesekjak and TheMug06 and removed request for a team November 13, 2025 17:44
@erenkarakal erenkarakal changed the title fix pattern Fix brew event pattern Nov 13, 2025
@ChicknTurtle
Copy link

ChicknTurtle commented Nov 13, 2025 •
edited
Loading

brew[ing] [complet[[e]d|ion]|finish[ed]] [(of|for) %-itemtypes/potioneffecttypes%]

Now complet and completd are valid but complete isn't

Absolutionism
Absolutionism requested changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@Absolutionism Absolutionism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my fault

Absolutionism
Absolutionism approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@Absolutionism Absolutionism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt this target patch?

@Absolutionism Absolutionism added 2.13 Targeting a 2.13.X version release. bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. labels Nov 13, 2025
@Absolutionism Absolutionism moved this to In Review in 2.13 Releases Nov 13, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Nov 13, 2025
@sovdeeth sovdeeth changed the base branch from dev/feature to dev/patch November 13, 2025 20:02
@sovdeeth sovdeeth requested a review from a team as a code owner November 13, 2025 20:02
@sovdeeth sovdeeth requested review from UnderscoreTud and removed request for a team November 13, 2025 20:02
@sovdeeth sovdeeth changed the base branch from dev/patch to dev/feature November 13, 2025 20:02
@sovdeeth
Copy link
Member

sovdeeth commented Nov 13, 2025

Shouldnt this target patch?

yes but eren needs to do a rebase for that to work

@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Nov 17, 2025
@sovdeeth
Copy link
Member

sovdeeth commented Nov 22, 2025

@erenkarakal please rebase on patch

@erenkarakal erenkarakal force-pushed the feature/fix-brew-event-pattern branch from 366c613 to 9eda3e5 Compare November 26, 2025 13:42
@erenkarakal erenkarakal changed the base branch from dev/feature to dev/patch November 26, 2025 13:43
@erenkarakal erenkarakal force-pushed the feature/fix-brew-event-pattern branch from 9eda3e5 to 4a9e2b3 Compare November 26, 2025 13:47
@skriptlang-automation skriptlang-automation bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Nov 26, 2025
@skriptlang-automation skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Nov 26, 2025
@erenkarakal erenkarakal force-pushed the feature/fix-brew-event-pattern branch 2 times, most recently from a10989d to 51c94cc Compare November 26, 2025 14:13
@erenkarakal erenkarakal force-pushed the feature/fix-brew-event-pattern branch from a0a191d to d46d9f5 Compare November 26, 2025 14:28
@sovdeeth sovdeeth merged commit e06d209 into SkriptLang:dev/patch Dec 2, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Dec 2, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Dec 2, 2025
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Efnilite Efnilite Efnilite approved these changes

@Absolutionism Absolutionism Absolutionism approved these changes

@TheMug06 TheMug06 TheMug06 approved these changes

@Pesekjak Pesekjak Awaiting requested review from Pesekjak Pesekjak is a code owner automatically assigned from SkriptLang/core-developers

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud UnderscoreTud was automatically assigned from SkriptLang/core-maintainers

@APickledWalrus APickledWalrus Awaiting requested review from APickledWalrus

Assignees

No one assigned

Labels

2.13 Targeting a 2.13.X version release. bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

No open projects
2.13 Releases
Status: Done - Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erenkarakal @ChicknTurtle @sovdeeth @Efnilite @Absolutionism @TheMug06

Comments