Skip to content

Cleanup ExprWorld and fix time state values#8401

Merged
sovdeeth merged 5 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/expr-world-time-state
Feb 1, 2026
Merged

Cleanup ExprWorld and fix time state values#8401
sovdeeth merged 5 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/expr-world-time-state

Conversation

@sovdeeth
Copy link
Member

Problem

former event-location's world was ambiguous and returning the wrong value sometimes, since former (event-location's world) was not properly handled.

Solution

Cleans up ExprWorld to modern standards. Reworks the get() method so that no matter the type of the input, if timestates are used it will return the correct value.

Testing Completed

Manual confirmation with:

on player teleport: 
    broadcast "%former (event-location's world)%"
    broadcast "%former (event-entity's world)%"
    broadcast "%(former event-location)'s world%"
    broadcast "%(former event-entity)'s world%" # intentionally errors
    broadcast "%former world%"
    broadcast "getFrom: %event.getFrom()%"
    broadcast "getTo: %event.getTo()%"

Supporting Information


Completes: Fixes #8200
Related: none
AI assistance: none

@sovdeeth sovdeeth requested a review from a team as a code owner January 25, 2026 00:21
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jan 25, 2026
@sovdeeth sovdeeth requested review from Pesekjak and cheeezburga and removed request for a team January 25, 2026 00:21
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jan 25, 2026
@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Jan 25, 2026
@sovdeeth sovdeeth linked an issue Jan 25, 2026 that may be closed by this pull request
1 task
@sovdeeth sovdeeth requested a review from Efnilite January 25, 2026 21:00
@skriptlang-automation skriptlang-automation bot added needs reviews A PR that needs additional reviews and removed needs reviews A PR that needs additional reviews labels Jan 25, 2026
@sovdeeth sovdeeth requested a review from Pesekjak January 25, 2026 22:58
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jan 25, 2026
@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Feb 1, 2026
@sovdeeth sovdeeth moved this from In Review to Awaiting Merge in 2.14 Releases Feb 1, 2026
@skriptlang-automation skriptlang-automation bot removed the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Feb 1, 2026
@skriptlang-automation skriptlang-automation bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Feb 1, 2026
@sovdeeth sovdeeth merged commit 53fa128 into SkriptLang:dev/patch Feb 1, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Feb 1, 2026
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Feb 1, 2026
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.14 Releases Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

Status: Done - Released

Development

Successfully merging this pull request may close these issues.

Past event-location's world don't work as expected

5 participants

Comments