Cleanup ExprWorld and fix time state values#8401
Merged
sovdeeth merged 5 commits intoSkriptLang:dev/patchfrom Feb 1, 2026
Merged
Cleanup ExprWorld and fix time state values#8401sovdeeth merged 5 commits intoSkriptLang:dev/patchfrom
sovdeeth merged 5 commits intoSkriptLang:dev/patchfrom
Conversation
1 task
Efnilite
previously requested changes
Jan 25, 2026
Pesekjak
requested changes
Jan 25, 2026
Pesekjak
approved these changes
Jan 25, 2026
APickledWalrus
approved these changes
Jan 26, 2026
Absolutionism
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
former event-location's worldwas ambiguous and returning the wrong value sometimes, sinceformer (event-location's world)was not properly handled.Solution
Cleans up ExprWorld to modern standards. Reworks the get() method so that no matter the type of the input, if timestates are used it will return the correct value.
Testing Completed
Manual confirmation with:
Supporting Information
Completes: Fixes #8200
Related: none
AI assistance: none