Improve event value cache#8647
Open
UnderscoreTud wants to merge 3 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
sovdeeth
approved these changes
May 15, 2026
APickledWalrus
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The event value registry doesn't take into account event validators when caching event value resolutions, this causes issues when an event value relies on external factors that are not constrained to just the event class. For example, skript-reflect's custom events register one skript event and rely on the identifier to figure out which custom event's logic to use. This causes Skript to wrongly cache event values as successful/failure and use the same cached result for all subsequent calls for that event value, no matter the custom event.
Solution
Include an option to exclude an event value from being cached if it depends on external contexts.
Testing Completed
EventValueRegistryTest.java
Supporting Information
Completes: none
Related: none
AI assistance: junie for writing most test cases