ENH: Add namespace to ITK autoload symbol#14
Draft
blowekamp wants to merge 1 commit intoSlicer:slicer-v5.4.5-2025-11-19-f51594afrom
Draft
ENH: Add namespace to ITK autoload symbol#14blowekamp wants to merge 1 commit intoSlicer:slicer-v5.4.5-2025-11-19-f51594afrom
blowekamp wants to merge 1 commit intoSlicer:slicer-v5.4.5-2025-11-19-f51594afrom
Conversation
Author
|
@dzenanz @lassoan Symbols in Slicer for the MRML IO will also need to be updated. Partially addresses Slicer/Slicer#8947 |
|
It looks good to me, too. Could you get the change in ITK so that we can backport it from there? @jcfr does it look good to you, too? |
The ITK plugin system autoloads libraries and checks for a defined symbol. Update this expected symbol to use the namespace. The load function is now defined as: ITK_LOAD_FUNCTION_NAME
blowekamp
force-pushed
the
itk_namespace_itkLoad
branch
from
ee13552 to
855c950
Compare
dzenanz
approved these changes
Jan 13, 2026
Author
It could me merged into the current ITK namespace change for one commit for the namespace changes. Unfortunately this current change has hardcoded slicer_itk namespace and is not suitable for being push upstream yet. I am not familiar with the history of this issue and PR in details enough. |
ruffsl
added a commit
to ruffsl/Slicer
that referenced
this pull request
Mar 17, 2026
Slicer's ITK fork (slicer-v5.4.5-2025-11-19) carries 6 patches beyond upstream ITK 5.4.5 that add APIs not available in system ITK: - AxesReorder enum on NrrdImageIO for 5D NRRD support (upstream in ITK master via InsightSoftwareConsortium/ITK#5476, but not in any 5.4.x release). vtkITKImageSequenceReader.cxx uses AxesReorder extensively (60+ call sites), making conditional compilation impractical. System ITK becomes feasible once ITK 5.5 releases with AxesReorder included. - Custom ITK namespace (slicer_itk) to avoid symbol conflicts when SimpleITK/ITK Python wheels are loaded alongside Slicer (Slicer#8947, Slicer/ITK#14 — draft, not yet suitable for upstream). This would remain the only blocker after ITK 5.5 and is optional unless loading external ITK Python packages. DCMTK must also revert to superbuild-managed: with ITK built by the superbuild, its bundled DCMTK would conflict with a system DCMTK at the symbol level (undefined references to OFConsole::instance() et al). System DCMTK only works cleanly with system ITK via ITK_USE_SYSTEM_DCMTK=ON in the slicerItk override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ITK plugin system autoload libraries and checks for a defined symbol. Update this expected symbol to use the namespace. The load function is now defined as: ITK_LOAD_FUNCTION_NAME