Skip to content

A handfull of suggested entity type tags for entity melting recipes#5527

Open
Sarinsa wants to merge 2 commits intoSlimeKnights:1.20.1from
Sarinsa:1.20.1
Open

A handfull of suggested entity type tags for entity melting recipes#5527
Sarinsa wants to merge 2 commits intoSlimeKnights:1.20.1from
Sarinsa:1.20.1

Conversation

@Sarinsa
Copy link

@Sarinsa Sarinsa commented Nov 28, 2025

Based on previous discussion, here are the tags I suggest to add. Personally, I will be utilizing most of them.
Recipes that were using vanilla or forge tags have not been changed.

@KnightMiner KnightMiner added Mod interaction Issue only happens when another mod is loaded Technical Pull requests making changes to workspace or targeted versions 1.20 Issue affects 1.20 labels Nov 28, 2025
@Sarinsa
Copy link
Author

Sarinsa commented Nov 28, 2025

I realize using forge and/or minecraft tags for some recipes and melting tags for others is a bit janky; entirely different scopes. For example, I think it better to use a "melting/skeletons" tag over "minecraft:skeletons", but this would obviously break existing "compat". What is your stance on this?

@KnightMiner
Copy link
Member

I don't see much point in switching tags. These are highly specific usecase tags, you want to tag your mobs to work in our recipes.

Skeletons you can already solve that with the general tag. Other mobs just lack such general tags.

@Sarinsa
Copy link
Author

Sarinsa commented Dec 7, 2025

The reason I thought of this is that some mobs tagged as "forge:whatever" may not thematically fit the recipe result or have drops that reflect the result.

After giving it a bit more thought, I realize if I am so invested in that stuff I am better off just taking the time to make the recipes I want and include it as default data on my end.

I will revert the removal of forge tag uses in the recipes and push that.

@KnightMiner
Copy link
Member

If such a case happens, it can always be fixed when we encounter it.

@KnightMiner KnightMiner added the Needs Update Issues or PR needs additional action to be taken by the reporter label Dec 24, 2025
@KnightMiner
Copy link
Member

Looks like some of my other tag changes conflicted with this PR, so I'll have to put it off until the inevitable 3.11.1 update. Once you get that resolved I can go ahead and merge this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20 Issue affects 1.20 Mod interaction Issue only happens when another mod is loaded Needs Update Issues or PR needs additional action to be taken by the reporter Technical Pull requests making changes to workspace or targeted versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants