Send real serial number, model number, and manufacturer to server#67
Merged
Conversation
kitlith
approved these changes
Jan 28, 2026
Member
kitlith
left a comment
kitlith
left a comment
There was a problem hiding this comment.
LGTM.
I was eyeing the querying of hmd_pose and hmd_prop_container, but that's just moved from later in the loop, and I'm pretty sure I'm the one that added the usage of hmd_prop_container in the first place, so.
(i think it might be worth looking into if we can cache that or not, but if it wasn't added in this PR, it's not this PR's concern.)
ButterscotchV
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SlimeVR/SlimeVR-Server#1731