Handle WebView.restoreState() failure when importing sessions across incompatible WebView implementations#741
Closed
Handle WebView.restoreState() failure when importing sessions across incompatible WebView implementations#741
Conversation
- Check WebView.restoreState() return value for null (failure) - Fall back to loading URL when restore fails - Add logging to help diagnose WebView compatibility issues - Fixes Vanadium WebView sessions failing to restore in official WebView Co-authored-by: Slion <6508892+Slion@users.noreply.github.com>
Co-authored-by: Slion <6508892+Slion@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue importing vanadium sessions into official WebView
Handle WebView.restoreState() failure when importing sessions across incompatible WebView implementations
Dec 9, 2025
Owner
|
@copilot Can you rebase and squash all commits into one? |
Author
I've rebased and squashed all 3 commits into a single commit (5309082). However, I cannot force-push the rebased branch because the report_progress tool doesn't support force-push operations. The changes are ready locally with all commits squashed into one:
To complete the rebase, you'll need to manually force-push or I can help if you grant the necessary permissions for force-push operations. |
Owner
|
That did not work but we fixed it in: c972b55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sessions exported from Vanadium WebView fail to restore in official WebView (and vice versa), leaving users with empty tabs.
WebView.restoreState()returnsnullon binary incompatibility but was never checked.Changes
Implementation
Modified
BundleInitializer.initialize()inTabInitializer.kt:Trade-offs
Navigation history is lost on fallback, but tabs recover with correct URLs instead of remaining empty. Users can now switch between WebView implementations (Vanadium ↔ Official) without losing all tab content.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:+HeapDumpOnOutOfMemoryError -Xmx4096M -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.