Merged
Conversation
added 25 commits
January 15, 2020 11:24
Added method getArtWork to get images for choiceManagers. Updated method createForecastChoiceSet() to use ChoiceCell Deleted Method getImageIcon as we doing use it anymore.
…hod createForecastChoiceSet() to use ChoiceCell Added method getArtWork to get images for choiceManagers. Updated method createForecastChoiceSet() to use ChoiceCell Deleted Method getImageIcon as we doing use it anymore. Deleted file Project.xml as it was commited by accident.
Fixed app icon issue, got rid of upload files methods and calls
Updated showWelcomMessage() method to use managers and had to add the addCommands() method call to the Completion listener and remove its original call form startProxy()
need to upgrade to menu manager and retest this feature
need to delete alot of commented out code still, just committing to save changes
Menu manager is now aligned with IOS, Deleted old code that was not being used
Added lock-screen capabilities edited current lock-screen layout and changed change unit choice set to display as tiles
Resets counter to 0 when switching between daily and hourly forecast
…code and got rid of old code
…played on screeens
…roadcast receivers
1 task
added 2 commits
May 11, 2020 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19
Updated applications to use:
Text and graphic manager.
Choice manager
Menu manager
Lock screen manager
When I updated the application to use the Text and graphics manager I replaced show request with the sdlManager.getScreenManager()... in SdlService.
There are two choice managers that were completely redone one for forecast and one to change units.
Both of these changes reside in SdlService
The menu was completely redone to use the menu managers. The menu functions differently now to align with IOS. When switching to daily and hourly forecast the menu no longer adds commands like next, back and previous to the menu. The menu also doesn't delete what page you are currently on.
all menu changes are in SdlService
I added back the lockscreen using the managers. I used the custom template that was already created, I just updated the template to make more sense by adding the app icon and name to it. Changes are in SdlService and lockscreen.xml file
Fixed broadcast receivers in SdlService to make the application work with TCP and added build Variants to switch between TCP and Multiplex connections